commit ee3ca154bbbe5a29e0cccd6cd8ed6701497d133e Author: Róman Joost Date: Mon Jul 23 12:27:17 2018 +1000 Automatic commit of release 25.5 Change-Id: I9cd4f7a44201fe356eb881025437cc1635458e8c commit ffc6bc62f4b1682d37354ebaa9d8c862fff678ee Author: Róman Joost Date: Fri Jul 20 17:05:41 2018 +1000 Add Jacob to the list of contributors Change-Id: I42a9b66654a761aa2ae930bab0526e3d9d59b626 commit 0883be69e6abc252cdc228eec7f2820a5b75fed5 Author: Róman Joost Date: Thu Jul 19 11:22:03 2018 +1000 Release notes for Beaker 25.5 Change-Id: Ibb5d5af3bea379729834248d523b967b852b5573 commit 27c58f217e9c69ae22f452842856d69da7869459 Author: Dan Callaghan Date: Fri Jul 6 10:45:41 2018 +1000 drop %clean section from beaker.spec The %clean section has been unnecessary since RHEL6. Change-Id: Ie8a607bfd28e4a5664332ab1452af913fcd98c81 commit b46e0f727551ff5eefb04af65c0476a03ce4b11a Author: Dan Callaghan Date: Fri Jul 6 10:43:51 2018 +1000 remove support for conditionally building the server bits in beaker.spec This was originally needed for RHEL5, where we continued supporting and building the client several years after we dropped support in the server. Nowadays, we are always building all subpackages everywhere, so we can simplify the spec a little by removing these conditionals. They will (hopefully) not be needed again in future. Change-Id: I9787bb056e9b0f3dd9f17714528fb3b21e4de420 commit 4cd3e354f750bd6e207df0d817712dbfe74dba6b Author: Dan Callaghan Date: Fri Jul 6 10:25:07 2018 +1000 add missing requirement on yum The server code imports and uses both the yum Python package and the rpmUtils Python package which is also provided by yum. rpmUtils is used at build time too due to the Sphinx docs. Change-Id: I310dc1a71196f5c59f2271edb22b306304ae0f9c commit d02e820351e4e63aff1f7baee47631f637448a02 Author: Dan Callaghan Date: Fri Jul 6 10:15:54 2018 +1000 explicitly invoke python2 instead of python In the latest Fedora releases, packages are forbidden from using /usr/bin/python (as opposed to /usr/bin/python2) and starting from Fedora 29 it is no longer available in the build root unless you explicitly depend on it. https://fedoraproject.org/wiki/Changes/Move_usr_bin_python_into_separate_package Switch to invoking /usr/bin/python2 everywhere instead. Change-Id: I8ffda44c8d1a2aa44d65e847d47338ac634089ff commit 27683275612c2a36f6f378f89ca197700488fce2 Author: Dan Callaghan Date: Fri Jul 6 10:08:04 2018 +1000 add conditionals to beaker.spec for new-style Python package names https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3 These package renames took place gradually over several Fedora releases, however from Fedora 29 onwards the old names are no longer provided so we have a hard cutoff where we need to use the new names. Change-Id: If630b8f94e4840a99eb21b7c10852173bd4b2579 commit 1615c1d7dcece62a55d4ae4083fcec8b919f1496 Author: Dan Callaghan Date: Fri Jul 6 09:49:01 2018 +1000 rearrange requirements in beaker.spec to live under each subpackage Change-Id: I275887af6e40c5afe6c75e3b7672fb734fd5b98e commit 96e7da128ce9419cebaae73df826d42e390e8c57 Author: Dan Callaghan Date: Fri Jul 6 09:33:49 2018 +1000 convert systemd conditionals to proper bcond in beaker.spec Change-Id: I7608bf3bb1485d0a5a6b12c1ea24b3af2294e2b1 commit 5dbeb4f7a7dfad403e142daec83b240da590eedc Author: Dan Callaghan Date: Fri Jul 6 09:31:50 2018 +1000 remove RHEL5 conditionals from beaker.spec Change-Id: I094f5bc85e33f9a47d6c5f0ff7d7a6f926c438cf commit 5fa87767adbbcbd19142eb925dd89c98e76a6ca6 Author: Dan Callaghan Date: Mon Jul 9 10:01:43 2018 +1000 tests: lsof moved to /usr/bin in recent Fedora Fixes this failure with the tests: ====================================================================== ERROR: test suite for ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/nose/suite.py", line 209, in run self.setUp() File "/usr/lib/python2.7/site-packages/nose/suite.py", line 292, in setUp self.setupContext(ancestor) File "/usr/lib/python2.7/site-packages/nose/suite.py", line 315, in setupContext try_run(context, names) File "/usr/lib/python2.7/site-packages/nose/util.py", line 471, in try_run return func() File "/usr/lib/python2.7/site-packages/bkr/inttest/__init__.py", line 431, in setup_package process.start() File "/usr/lib/python2.7/site-packages/bkr/inttest/__init__.py", line 180, in start self._wait_for_listen(self.listen_port) File "/usr/lib/python2.7/site-packages/bkr/inttest/__init__.py", line 190, in _wait_for_listen if check_listen(self.listen_port): File "/usr/lib/python2.7/site-packages/bkr/inttest/__init__.py", line 134, in check_listen stdout=subprocess.PIPE, stderr=subprocess.PIPE).communicate() File "/usr/lib64/python2.7/subprocess.py", line 394, in __init__ errread, errwrite) File "/usr/lib64/python2.7/subprocess.py", line 1047, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory Change-Id: I3cb75e16b2036584d9670e2439b5eb756d147b8b commit d64c4facaccf285ea2c71d8c39801c4e72a1121b Author: Dan Callaghan Date: Fri Jul 6 15:18:55 2018 +1000 work around Bootstrap 2.3 incompatibility with Less 2.7 Bug: 1369590 Change-Id: I422edd26ddca09488efb7fbbad0b445110876938 commit bc73fd36f160de9ea7be69a694c0fccfcd7db6ac Author: Jacob McKenzie Date: Tue Jun 19 15:49:14 2018 +1000 Always truncate old/new values for Activity model When using MySQL, the db could handle being passed a User object and would truncate it appropriately. There was prexisting code to truncate the new/old values but it only expected unicode and was skipping User objects (Which is what is passed to Activity when a system owner is changed). As MariaDB is not so leanient this causes failures. This fix will cast all objects passed in to unicode and then truncate them; as was originally intended. Bug: 1591391 Change-Id: I43c9601a83d042a28547475970e222f87ad1c9cc commit e48edf3d33de1caff0ec90ced4d379b2b5e2ec7a Author: Dan Callaghan Date: Thu Jun 21 11:32:23 2018 +1000 delete unnecessary unicode_truncate() function This was added way back in commit d917d76a because we observed that MySQL appeared to be truncating string values in the middle of UTF-8 characters, leaving behind invalid bytes. The *actual* cause of that was because Beaker was connecting to the database with latin1 encoding. The column was 60 chars so MySQL truncated the string at 60 *bytes*. After we switched the database encoding to utf8 in commit f47cf808, this was no longer an issue -- MySQL would correctly limit the field to 60 Unicode *characters* instead of 60 bytes. Change-Id: I54fab1686106ab26743f69ee97aee80686eb8342 commit ba6833daa33fc997acb0db209c79ff833adbbc61 Author: Róman Joost Date: Wed Jun 27 14:13:19 2018 +1000 Handle RHEL8 synced to partners as well The current distro import code will not be able to import RHEL8 Alpha composes synced to partner repositories. What complicates this is a different directory structure between partner repos and internal repos. This patch adds support for importing RHEL8 alpha internally and for partners adding code which tries to guess the directory layout. Bug: 1593042 Change-Id: Ib9219d051b1b76cd5c7863a6cd012b9ed29d7d19 commit 845aad4aba4706c9cd9b4d4ea71c1b109e7c20f2 Author: Jacob McKenzie Date: Wed Jun 20 11:23:42 2018 +1000 Make Jobs page's `autofetch` wait for response The `autofetch` method will now wait for a response from beaker server before sending another ajax request. Requests will also timeout after 10 minutes, then be retried. Bug: 1505207 Change-Id: I1bbf4c75e6fe751baebfb9e38ee1856634a1cbd9 commit 66e257fcce3553bf18b61c9e02af2190ced4c5f9 Author: Dan Callaghan Date: Tue Jun 5 08:59:54 2018 +1000 docs: mention SKIP as a valid result type Change-Id: Ifdeeb5acdf5f542d89e7acfa38ffe677b0262638 commit 7482fa0a19366225d32ea221cac7af85f57d231f Author: Dan Callaghan Date: Thu Jun 7 17:44:43 2018 +1000 lock recipe and related rows when registering or changing logs To prevent deadlocks with other transactions which could be concurrently updating the recipe row, such as update_dirty_jobs(). Bug: 1065202 Change-Id: I62db79a6cea650a0732ef25f8952e027b829f9f8 commit 89b4aa74df12abcfe841ec36ff6655a12504c24a Author: Dan Callaghan Date: Tue Jun 12 16:29:25 2018 +1000 docs: describe how custom partitioning works Change-Id: I823b25b0111f12f8389f46b03dfc69842be466e8 commit 9a0aae51462cfeb59cb419e72eed39aba765354e Author: Róman Joost Date: Thu Jun 14 12:17:15 2018 +1000 Allow to import RHEL8 Alpha This patch allows to import RHEL8 Alpha composes. The compose paths are hard coded and any deploys which provide the compose should follow the hard coded naming scheme of folders in order for the importer to import the compose. Reasons for this are, that once available the name of the composes should and will not change. Change-Id: I43d7fa1749822cad98138d2b4d64916f6f0166d2 commit 8272f60928e7100a074382fd837e0c8f9b4b53be Author: Dan Callaghan Date: Thu Jun 7 12:15:13 2018 +1000 set appropriate headers on automatically generated mails This is to try and avoid pointless vacation auto-replies going to Beaker. Bug: 1588263 Change-Id: Idd5b5261f93b1fd29ca2516b0acd4b00e11fbe6f commit f32bb83d66c447ef40536536883e960096046f9f Author: Dan Callaghan Date: Wed May 30 12:41:12 2018 +1000 beaker-log-delete: avoid holding open a database transaction outside the loop Similar to commit 48cda168, beaker-log-delete may run for a long time if it has a lot of jobs to purge. We want to avoid having an active transaction for the entire duration of the run, because it puts extra strain on Innodb and may contribute to the likelihood of bug 1574772 occurring. Change-Id: Ifd0243eea18d57892d24098610b23d8aab8e31dd commit d64838327b4c787b697955bac29a32a711337c09 Author: Róman Joost Date: Wed Jun 6 13:14:57 2018 +1000 Coerce score to int MySQL 5.x style With the switch to MariaDB, the database is less tolerant of different types than what is declared in the schema. The production instance is running in strict mode, which enforces this schema. MySQL would simply coerce the string to an integer depending on what you have passed in, MariaDB raises an error. In order to keep backwards compatibility, we do in Python what MySQL did. Bug: 1586049 Change-Id: I500db2e313f5563a75a7cf9cd6563cd5d090f6eb commit 9e1acd658848d27b777a9eb06e573e89740a1d2f Author: Jacob McKenzie Date: Fri May 25 14:13:41 2018 +1000 Make Oops regex less aggressive The regex for kernel oops' was too aggressive, so it has been replaced with a moderate one, based on data from oops.kernel.org. Unit testing was added for the PanicDetector. Bug: 1574317 Change-Id: I47d1689def28426801bb4277de41560040f17406