commit c175a7207f0f59b4152c48787b12873d7e1ad361
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Thu Jan 14 14:17:55 2016 +1000
Automatic commit of release 22.0
commit fba885c48a22a6d12155a131f35c4771feee7c63
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Tue Jan 5 15:47:39 2016 +1000
fix parsing of reservesys element in recipe XML
Testing truthiness of lxml elements is bad because it actually tests
their length (number of child elements) which is not the intuitive
behaviour. In this case we really wanted to test for non-Noneness.
Bug: 1295642
Change-Id: Iae907aae8cc74b513a4e02e25e833abe10916a2f
commit 776f42d2e4a874dbb7f8069427925d2705a91a7d
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Tue Jan 5 15:40:05 2016 +1000
test_jobs: simplify transaction handling
We can just wrap the whole thing in a begin/rollback, similar to the
approach used in all the existing model tests. This lets us avoid any
transaction handling in the test methods.
Change-Id: Ie3229b34b9ae1d174039960d8e0ab5ed5b8640a4
commit 5ed1b2dda8c591285daad0c62695c4e0e7ff95f6
Author: Roman Joost <rjoost@redhat.com>
Date: Tue Dec 22 13:53:32 2015 +1000
Fix cause of memory leak in tests
This fixes the cause of a memory leak when running wizard test cases.
`mkdtemp` created temporary directories with an underscore which the
wizard detected as invalid package names. To avoid that, this fix
creates a sub directory inside the temporary directory which is always
valid to avoid the wizard ending up in an infinite loop waiting for
input.
Change-Id: I30c394c4381bc88c8c3ba41726b6010853b15332
commit a475b998f2932cb0ffa6dd84ba71cc80626fac57
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Wed Dec 23 10:14:05 2015 +1000
Automatic commit of release 22.0rc1
commit f04e0ae3527d288beb58842c8f08274bb3a99b3b
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Tue Dec 22 14:07:50 2015 +1000
JUnit XML: don't report duration for overall task
In the JUnit XML results we include a <testcase/> for the overall task
(in addition to all its results) so that we have somewhere to put the
task logs. However we *don't* want to include a duration for the overall
task because that will be summed with the individual result durations
making the task look like it took twice as long as it really did.
Bug: 1291107
Change-Id: If58689c543b9aab68b78cbc660e43f20ed5389f6
commit 3f2ba164e85cfff75a335bb1935a1e5da9240356
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Tue Dec 22 14:03:37 2015 +1000
release notes for 22.0
Change-Id: I1bbe7b8b7a9296602d6f5b7b34bdc27609c2f57a
commit 1e75435863b24c8f29343d04eff5ead4b9adc025
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Mon Dec 21 12:03:17 2015 +1000
generate_release_notes.py: update contributor names
Change-Id: I2402983f9d9e5b04a224748e75b5a076526d432c
commit 304aadaa74afdb2887843b99adaaaacd95267f96
Author: Roman Joost <rjoost@redhat.com>
Date: Wed Dec 9 10:56:07 2015 +1000
Replace reserve report with system grid
This replaces the old reserve report with the new system search showing
reservation time. The report sorts by longest (oldest first) reservation
time. The columns have been slightly tweaked to include: Loaned To and
System Pools by default (see Bug 1279463).
Bug: 623562
Change-Id: I3677ed8e1429ea34ee99c01c490bf769516760c6
commit 706baf4655e9e6bc827c4e7903424a9da91e9a95
Author: Roman Joost <rjoost@redhat.com>
Date: Fri Nov 20 13:42:37 2015 +1000
Show reserved status in system grid
Allow users to search and sort for systems by a reservation date. This
allows spotting systems which are reserved for too long by users.
Bug: 623562
Change-Id: Icbb4605365ce4608d01f5761dcfba3b99bd8b3dc
commit 3ce23cb58f937c400c37e6371975f71512a8844e
Author: Roman Joost <rjoost@redhat.com>
Date: Tue Dec 8 16:05:24 2015 +1000
Refactor tests to use a helper method
Most of the test methods use the same actions to prepare data for the
search form. This re-factoring encapsulates this in a helper to be used
by all test methods.
Change-Id: I6eaad0bc363190f902d4cc8bc30688d1d4efcba7
commit 0999ae2c4bce84cf5da755378ddf40cb5788178b
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Thu Dec 17 16:23:56 2015 +1000
tests: catch and report excessive output from beaker-wizard
Change-Id: I57624922abe09f2feb9f669832e98add79b88711
commit 2f557593f21379ada4f77967d20c01b4b8c5fc24
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Tue Dec 15 11:48:05 2015 +1000
add "bouncer" URLs for job logs, to redirect to the real location
Bug: 1291130
Change-Id: Ica6d833534a02444947e912a9efa7010d3d08bdb
commit 93dadff4765c4b20ba5555929503ea76d02e91a3
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Tue Dec 15 09:38:37 2015 +1000
better handling of empty result names and leading slashes in JUnit XML
Bug: 1291112
Change-Id: Ieb0db2afb9ac6d9e31c314e4650eb446a8d2a3cc
commit e5c450d74a2f9707eff2f2f045cd4a74eb7054e1
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Mon Dec 14 17:46:22 2015 +1000
add time="" attribute in JUnit XML output
Bug: 1291107
Change-Id: I1ef47b6bfab350d0466203497f29cd76d931f6d6
commit 9c1c94ec3fb3853f28bd08ec90508f1fb72de9aa
Author: Roman Joost <rjoost@redhat.com>
Date: Fri Dec 11 13:59:53 2015 +1000
Fix bug when editing labcontrollers after creating
This patch fixes a problem of a missing id being sent back to the
backbone model resulting in errors upon editing the newly created lab
controller.
It also fixes duplicated modals being left upon closing the dialog.
Bug: 1290266
Change-Id: Ic4d399ff42c3c962cdee4915896d8ecd5e3d0666
commit 7b3b73e8a4b88d18c0a79483b744a543970d20da
Author: Hao Chang Yu <hyu@redhat.com>
Date: Wed Dec 2 01:47:59 2015 -0500
Add submission delegate support for bkr job-submit and job-clone
bug: 1215138
Change-Id: I1ef81b0c36b78cdbccf72452f863c3103c18ec45
commit 79d46088c9e6d126e16cf929924b8675981c6fd9
Author: Matt Jia <mjia@redhat.com>
Date: Wed Dec 2 15:18:24 2015 +1000
inverted group page
Bug: 1220610
Change-Id: I6b14cf0163b0c0662da96c473eeb8017a2bf4d20
commit 1444232c2a93d3cae59b474f300d0c8de85bff21
Author: Matt Jia <mjia@redhat.com>
Date: Wed Nov 11 15:41:19 2015 +1000
HTTP API for inverted group page
Bug: 1220610
Change-Id: I5f8f8c27e5720fd3804d88359a46b3acb7dd80b3
commit 4081ab1a2a6b4bb8ac97d426dd55f508ef4cf0ad
Author: Matt Jia <mjia@redhat.com>
Date: Tue Jul 28 16:21:11 2015 +1000
add support for inverted groups
This patch does the following things:
* introduces group membership type which is Normal, Ldap or Inverted
* updates the group APIs to handle the new group membership type
* fixes the existing tests to work with the new group membership type
Bug: 1220610
Change-Id: If7fdc93724be09bf7ce95c5de12ade4100d8a24f
commit 331795ecf13c67a8a82da86ef9a2b188d189d481
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Tue Dec 8 15:34:05 2015 +1000
tests: fix activity assertions in test_remove_account
Group.activity doesn't have an ordering (unlike most of the other
activity relationships, which order by id descending) so the latest
entries are actually at the end, not the start.
Change-Id: I4e76265b0336f69f5837f54a583964878f8881c9
commit 08aeea96ebc4e073ebfafaf47379638625a68ae0
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Mon Dec 7 13:37:35 2015 +1000
linearize Alembic migrations
Change-Id: I16b77f969a320da6c47f94eb4f4ff96bffe6ea50
commit 01ade90cd770694045199e0bb0fbb2814ee29dd1
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Tue Dec 1 17:46:52 2015 +1000
remove users from all groups and policies when their account is removed
Bug: 1257020
Change-Id: Ibf12ced6d3a0cb973b20385276e34ab620a22317
commit 2bfc0f4875a8c50be898141766a92490b9b07114
Author: Alexander Todorov <atodorov@redhat.com>
Date: Sat Nov 28 01:23:20 2015 +0200
bkr job-submit: add more usage info
Change-Id: Ib340af252650ece566c2d6129438021fe15cd5c7
commit c41cd4ca82915ae755b43ef0dca1ab204175ec14
Author: Roman Joost <rjoost@redhat.com>
Date: Wed Nov 11 11:51:56 2015 +1000
Preserve arbitrary XML
This patch preserves arbitrary XML elements in the Job definition only
if they are using a namespace.
Bug: 1112131
Change-Id: I6e8d3a77c53c32730146a7e54ba32651d6293fb2
commit c37dc9d4997ddcecce3f4461a0fece5c44924fab
Author: Roman Joost <rjoost@redhat.com>
Date: Thu Nov 5 15:57:41 2015 +1000
Use lxml.etree for XML import/export
This refactors the import/export XML parsing to use lxml.etree instead
xmltramp and xml.dom.minidom.
Notable changes:
* the job whiteboard does not normalise whitespace anymore
Change-Id: I41f891fc5d3b96e6824118c7480d108d52b1aedd
commit 54d92bffaaf7305e8b3142b74c0a1930b59b3c03
Author: Roman Joost <rjoost@redhat.com>
Date: Tue Dec 1 14:18:15 2015 +1000
client: use lxml to avoid PyXML side effects
This changes the (pretty-) printing code of XML received from the Beaker
XMLRPC end point to use lxml. On systems with an installed PyXML package
the output can change which can lead to side effects.
Change-Id: Iee7344e879a38737724e4b45c48fe98f6df4e47d
commit 75e14f7e475e659b0df6a9ee5f51b70fd005f2d0
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Wed Dec 2 14:37:47 2015 +1000
docs: tweak ignoredisk description to try and be a little clearer
The need for two "=" is a bit strange and may look like an error to the
reader, so let's mention specifically that it's necessary.
Change-Id: I1ec71bcac5a7d8917f5c57664dec8637969bd6de
commit aaf541a7744f46caedb23916c293305e4f4097b5
Author: Matt Jia <mjia@redhat.com>
Date: Tue Nov 24 14:19:54 2015 +1000
update all the conventions to use group.add_member or group.remove_member
Also gets rid of the associationproxy from both the User class and the Group
class.
Bug: 1220610
Change-Id: Idf34b0860e8acecdd96c32b16cdee9d980edd572
commit 168413abc8f7dc91f4aee38a725874ee8f21ff9a
Author: Matt Jia <mjia@redhat.com>
Date: Tue Nov 24 15:36:24 2015 +1000
test_distros: fix a test which messes up the global admin user permissions
The DistroExpireXmlRpcTest shoud not be dealing with permissions on the global
admin group.
Change-Id: Ie41ed23cff78d47489324d8f162008b705f3e63e
commit 97075a2f3976a59e1403fe2f9dd1622136159bdc
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Nov 27 15:03:00 2015 +1000
disable implicit job sharing
Bug: 1280178
Change-Id: I75a7a3848221faf75326ea33dbf982787e13917d
commit 4dae92ed22d479d0d5d6da3459f14da23e4a2d43
Author: Matt Jia <mjia@redhat.com>
Date: Wed Nov 25 13:55:19 2015 +1000
LDAP groups should not have any owners
In d3993d21, it allows to modify LDAP group ownership.
However, the owners will be removed after syncing from
the LDAP server. So we should stick with the old behavior
that LDAP groups don't have any owners.
Bug: 1220610
Change-Id: I5848b30e2b8f945aaa40c6f98b6acf9ef9295e82
commit b8b36b2acc09c0583be793a3db3fa20c3151e5b6
Author: Roman Joost <rjoost@redhat.com>
Date: Fri Aug 7 11:23:13 2015 +1000
labcontroller: API to edit lab controllers
This patch adds API end points for an upcoming change to port the lab
controllers edit page to backbone.
Bug: 1251355
Change-Id: I6fa5f319aabd7741d9656cc5ae0e54c2d565b693
commit e18232b67eef110f1275500e5a99c9f307275e63
Author: Roman Joost <rjoost@redhat.com>
Date: Thu Nov 19 11:16:19 2015 +1000
Fix error when adding a duplicate key type
Bug: 979270
Change-Id: Ia94f8f9dc32f4febd876f429f9f93aed87682b11
commit 79f44ecc5daf7a3b383d1b92e88939d85ad47186
Author: Roman Joost <rjoost@redhat.com>
Date: Wed Nov 18 15:59:04 2015 +1000
Fix error when adding numeric key type
This fixes a server error when adding a numeric key type.
Bug: 970921
Change-Id: I0e375b46a5fcd9cc4d775e5a34aea168586dc1ff
commit 4cb34a283d88923cd5567b85fefc463a1857d75a
Author: Roman Joost <rjoost@redhat.com>
Date: Wed Nov 25 13:26:07 2015 +1000
Fix botched test
This test was overwriting the expected result with the actual result and
comparing it to itself, which meant the test always passed.
Change-Id: I123c68ffb5cbde1608fc777398fe1a9c1712b13e
commit 4b5c75b9f6a028dd220113a890a5820895b8e58d
Author: Roman Joost <rjoost@redhat.com>
Date: Thu Nov 19 12:21:15 2015 +1000
Expose disk details in system JSON
Bug: 1206033
Change-Id: I6a413828db553dcd94d3ca102d45508acac96c8d
commit f46e7d10b3f37890c88894cf03c3d4a11c1b2d69
Author: Roman Joost <rjoost@redhat.com>
Date: Thu Nov 19 15:27:22 2015 +1000
Expose full CPU details in system JSON
Bug: 1206034
Change-Id: I8bc2cfae07b4a8c622dc58d22aafc80115ec5737
commit d607c6a5d3521ea6e33ea71d67f668fbd7b1d98b
Author: Matt Jia <mjia@redhat.com>
Date: Mon Nov 23 09:54:15 2015 +1000
fix the rhts version in beaker 21.2 release notes
Change-Id: I84e10e2d020479737f877b3a338c4eca707b0106
commit 48bc51b0101f33f1e68ab560f1674e9a099fe812
Author: Matt Jia <mjia@redhat.com>
Date: Tue Nov 17 13:51:01 2015 +1000
Automatic commit of release 21.2
Change-Id: Idaceaa00a0f60cf82dc0f8300335823adb3292a8
commit e155802f5d693bbe8d9c2dbbe3c1099495e99170
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Thu Nov 5 16:54:10 2015 +1000
test_database_migration: add test case for Beaker 21 schema
Change-Id: Id4c59916542a0474157161d15a3cec1ef464659c
commit 5d51fe4605b6c74a0583a5c25000afea542e0f24
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Wed Oct 28 20:51:21 2015 +1000
replace /groups/mine with a search by member on the groups grid
Bug: 1275999
Change-Id: Idf45b272ab52243eaac3bba85bb612691d5d6ae9
commit 4f1f40347a46035ef2e69858d8e360107c04af29
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Wed Oct 28 20:32:17 2015 +1000
groups grid: allow searching by member and owner
Bug: 1275999
Change-Id: I273a0706a667186b372fb77a26139d54f63018cc
commit 478a293875d76612ba75091835a14c7444660b8b
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Wed Oct 28 19:50:06 2015 +1000
expanded lucene_to_sqlalchemy to handle .any() for one-to-many relationships
Bug: 1275999
Change-Id: I1a2387398b2fd203e56391b9252d1efe20bcb79a
commit e6f2a9d2bd77e8d08e425b2150482d56aa175147
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Tue Oct 13 11:56:34 2015 +1000
ported groups page to Backgrid
Bug: 1275999
Change-Id: I631a22c8964a4f335f86d550fa3294cd1bb9eb52
commit fa8323e51ba02512a050bc65d1d0c8c7a34f8280
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Mon Oct 12 18:17:33 2015 +1000
Delete button on group page
Bug: 1275999
Change-Id: I9d63726aa8c0adb1a70671f4fcd5e6cf13349008
commit b38a76d750e1a7db7aed5989557788a59d135643
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Mon Nov 2 10:56:38 2015 +1000
rpmlint config
Fixed one outstanding rpmlint error, added a config file to whitelist
all the remaining ones which can be ignored.
This will let us invoke rpmlint in our Jenkins build to ensure we don't
introduce any new warnings or errors.
Change-Id: Id32465343f41348f4eb80db2dfd84381ec178c7f
commit 6c8c7cae1a29b540b350c461a4d3907044612d01
Author: Matt Jia <mjia@redhat.com>
Date: Thu Oct 15 12:01:24 2015 +1000
HTTP API for new recipe page
Bug: 1263918
Change-Id: Ib89e1395d0d93c3bf515e2789df3cd327fd2a680
commit d9323cf33a70048539990e168eea43f144aff6a0
Author: Matt Jia <mjia@redhat.com>
Date: Thu Oct 15 09:59:36 2015 +1000
record recipe activities
This patch is for recording recipe whiteboard modification, reservation
extension and release.
Bug: 1263918
Change-Id: I4acd2ab814542ebcc405fbf60cfad0001ddae8d3
commit f35c5f1d5aff5c46d681614085e3100264c22b16
Author: Matt Jia <mjia@redhat.com>
Date: Tue Oct 27 14:14:05 2015 +1000
bkr job-modify --priority
This patch allows privileged users to change job/recipeset priority from
CLI.
Bug: 1149977
Change-Id: Ifa6c3672f96a6bb5bf384b538075b8ca147fe3e9
commit ee7a31ab930db37d9df94c0e02e756083a66a1e1
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 23 16:52:34 2015 +1000
bkr job-results --format=junit-xml
Bug: 1123244
Change-Id: Ie8c3a6edb541a4e2e6147390a602020442b15729
commit e81b37810d9ef170a9373da40967a34db572a45e
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 23 15:15:23 2015 +1000
export job results as JUnit XML
Bug: 1123244
Change-Id: If1b1423900b70faabf902a7d779ce1cc76ff8ce1
commit a415bebb4d423cfdc6b17141e728fb80f5105df0
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 23 15:07:30 2015 +1000
refactored RecipeTaskResult.short_path to just return a path
Introduced a new property display_label which preserves the previous
behaviour of short_path, where the log is shown if the path is empty,
which is really a display issue specific to the tasks widget.
This is needed so that we can use short_path in JUnit XML to get just
a path.
Bug: 1123244
Change-Id: Id875daa7e68970d856635b83906d7e7e2118c278
commit b7a29fc8a5d2d52f346db5d03d9808799fa3ae4a
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 23 15:13:01 2015 +1000
tests: populate database properly in server unit tests
Currently it is just creating the tables but not inserting all the
"constants"/pre-defined rows we expect to be present, such as config
items. We need those for all the model code and data_setup to work
properly.
Change-Id: I894f611dac819580455631d53bd8b217fccff267
commit 3cd36577fef079a2ef4d820c8befb05eb424c480
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 23 15:11:25 2015 +1000
fix incorrect RecipeTaskResult construction
Appending the new instance to the list *and* setting its recipetask
attribute will cause it to appear in the list twice. Normally it's not
noticeable (they are still a single row in the database) except within
a single transaction, which happens in the unit tests.
Change-Id: Ic831bb3a9bd2ce35346952329b070801abae892c
commit ce2624373370bc3dddb8c01f7424f87e3c04bc56
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 23 13:48:06 2015 +1000
fix primary key on config value tables
The config_value_string and config_value_int tables have a composite
primary key across (id, config_item_id). Not for any particular reason,
since id is already autoincrementing. Probably it was originally
intended to be (config_item_id, valid_from) or similar.
The composite PK does not in itself cause any problems, but in SQLite
for unit tests it causes the id autoincrementing not to work. So this
patch changes the PK to be just on (id), which has equivalent behaviour
but lets unit tests create config values.
Change-Id: Ief1bfb3d9c1d21552ba9aab7e2072b8fc4ea20d9
commit 3be5bdd3a62776c9bd1c74dbe4381a70c839b93a
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Wed Oct 21 16:42:48 2015 +1000
find expired jobs by queue_time if finish_time is NULL
This means the log deletion process will now also find old Cancelled and
Aborted jobs where a recipe never started (in which case start_time and
finish_time are both NULL even though the job really is finished).
Bug: 1273302
Change-Id: Icece359f1e4fcc47d24176a1d0805055220fb772
commit 125f69fc28e58c51f868560629d2c234f6f3955e
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 16 15:55:48 2015 +1000
automatically create user accounts from REMOTE_USER_* variables
Bug: 1112925
Change-Id: Ic31866a82d9f1b1984f0466b776b675003c9a9c0
commit 086b86d2c5ef6471a348edfe26e09cfcc1583a74
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Wed Oct 21 15:35:57 2015 +1000
Misc/rpmbuild.sh: git rev-list in RHEL6 has no --count
commit d6743953640a61750867b8c8c6a4e26b5c50aa27
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Thu Oct 15 13:36:55 2015 +1000
fix circular reference in system JSON for in-progress hardware scan
Bug: 1263917
Change-Id: I02c9afbc29b54780a6d5a28b2da44bdc2760960b
commit 58e4ec8fec16dc6881cfddb6834d17c2bdb26f58
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Mon Oct 19 11:05:48 2015 +1000
don't run unit tests with integration tests
For historical reasons we have always just run all tests as part of the
IntegrationTests/run-tests.sh script, since there wasn't really anywhere
better to run them. However we now have separate scripts (and make
targets) for running unit tests in each of the source trees, so we don't
need to run them here too.
The reason to avoid running unit tests as part of the integration test
suite is that it's sometimes difficult to write unit tests which work
properly as both a regular unit test and also with the integration test
config, which is substantially different. I discovered this when working
on unit tests for bkr.server.identity in bug 1112925.
(Also dropped rhts from the nose invocation because it doesn't need to
be there anymore, we stopped using any rhts modules in Beaker ages ago
in commit 3348ae74.)
Change-Id: I866e018d50d154f7271a7af33b15ec56cc183412
commit b8778c1a3851b4f515c438044f01ca2773f50092
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 16 15:52:55 2015 +1000
unit tests for bkr.server.identity.check_authentication
Change-Id: I6b6ad570f8bad63cd4768e7884f534876634af0b
commit cbcb4e8ada98e1d2979c5448b704a6c7aa252aac
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Wed Oct 21 10:36:22 2015 +1000
Misc/rpmbuild.sh: ensure NVR for develop does not decrease when a minor release is tagged
Currently the RPM release has 0.git.${count}.${sha} where the count is
the number of commits since the most recent tag. However that means when
we tag a minor release (e.g. 21.1) and merge it into develop (e.g.
22.0-0.git...), the commit count *decreases*, even though the RPM
release should continue to *increase*.
We can avoid that by counting commits from the previous major release
instead of just the nearest tag, so that we get 22.0-0.git.58.22f027d
which is 58 commits from 21.0.
commit 2d9612f687d77d69a195565ee529e0e8671eefe7
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 16 11:52:24 2015 +1000
add SQLite support for ConditionalInsert
Previously this hardcoded some MySQL-isms, which meant it didn't work in
SQLite. As a consequence, any code calling lazy_create(), which is
almost everything, could not be used in unit tests running against
SQLite and had to be in IntegrationTests so that it ran against MySQL.
This lets us write more unit tests that don't need an entire MySQL
server to run.
Change-Id: Id04bbefbacf92e77400ebbcc77b2828d75125b25
commit b51ffa00e8476596bbba8b3e4c9ab8f2c8f8daf4
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Mon Oct 12 10:45:38 2015 +1000
test_power_types: fix timing issue
The tests were not waiting for the action to complete client-side before
asserting in the database, so they can fail if the client is slow
enough.
Also fixed the loading behaviour for the Add button.
Change-Id: I2c06078f5f588d5f77100e0502684129953a6985
commit c25f942929dda447175f25c3cc6c983b076c5da7
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Tue Oct 13 11:39:02 2015 +1000
tidy up some dead code from the old group page
Change-Id: I99f0156071430af6c0fdd6af52f721cd4761c257
commit af171a08222e56ced9c6528cb028350f1b4e6b27
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 9 15:32:27 2015 +1000
Let the lab controller decide what the default install method should be
Based on a patch contributed by Jun'ichi NOMURA
<j-nomura@ce.jp.nec.com>.
Bug: 1220652
Change-Id: I29fb392646ee7f11f41ff9866f8b3b27500cc83f
commit d9395bd3e0c9f0676edd421bb789048b1064bf05
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Tue Sep 29 10:45:38 2015 +1000
upgrade bootstrap-select to 1.7.3
The latest version has a useful feature data-live-search="true" which
shows a text input field for filtering the options in the dropdown.
We will need that for the product selector on the job page since there
will be hundreds of products.
Change-Id: I8b94689fbe52bf62b99b9b90bcf0a13120dd2344
commit 20e21381d57205cfff12ab6fbb7941bd28927bfd
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Wed Sep 30 09:35:46 2015 +1000
HTTP API for new job page
Bug: 1263917
Change-Id: Ic555bec36c8b5ef14ba4bef92bb5451bacc0ff1f
commit abd51384118b957b2ffb918fd76111f2d031b80c
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 2 12:27:20 2015 +1000
group page: only reset Add button when group model is updated
This patch makes the Group model responsible for ensuring itself is
updated after adding or removing members/groups/permissions, rather than
leaving it up to the view.
The bug in this case was that the views were resetting their button
before model.fetch() had completed. The button would stop spinning but
then some time after that the list would update itself. This is fixed by
using .then() to chain model.fetch().
Bug: 1251356
Change-Id: I6e1564594334ce2521577702345279f3e2585ba7
commit 208c77051d558510430f3f5ad673f732279158f1
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 2 12:16:54 2015 +1000
sort members and owners on the group page
Bug: 1251356
Change-Id: I9504f349ed71a53f125af9372619758bfabae9cc
commit aebfe977022028ffdc22f458f1b7c58a83d4bdc5
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Oct 2 12:10:55 2015 +1000
fix group activity to correctly record the user performing the action
Bug: 1251356
Change-Id: I783d0d50a264243f97fc21b821dcc94a9f4f74d3
commit cc7ad3f5138a63de2b3a8468f7b5cb2c00b236a3
Author: Matt Jia <mjia@redhat.com>
Date: Thu Oct 1 09:30:06 2015 +1000
do not use boostrap-growl for showing the error message
When adding a bad group member, owner or permission on the group page,
the error message should be shown below the form.
Change-Id: Ib8d14920380002e71a56b9383a6fbea0433ea8ce
commit aff62436c518f5150d9a47e0869a11ece81b2b01
Author: Roman Joost <rjoost@redhat.com>
Date: Tue Sep 29 09:38:16 2015 +1000
tests: consistent use of fixtures
This patch changes all inconsistently named fixtures to use unittest2
style class level fixture methods.
Change-Id: I3a64a83c36b916b5bfa626ed46f0def415362148
commit 83926105c7d79524004d505559233bd8114b3d4b
Author: Roman Joost <rjoost@redhat.com>
Date: Tue Sep 29 09:53:00 2015 +1000
tests: use unittest2 compatible skiptest markers
Use unittest compatible markers instead of nose only markers. That will
make our code base future proof with the Python standard library.
Change-Id: I5b17c2bcdee7d02d9d7308be0a986e785f3d2480
commit 1c37a0cc1c64932fc3d0763ed72727dea2be5ed6
Author: Roman Joost <rjoost@redhat.com>
Date: Wed Sep 30 14:45:11 2015 +1000
tests: fix timing issue with bootstrapGrowl
Fix an assertion which failed from time to time due to a timing issue
with bootstrapGrowl.
Change-Id: I717551111ae32574bf85eee4f59e11517fcb25bb
commit db06d1d308603629322b7a90d89fd853ccb4fb8f
Author: Roman Joost <rjoost@redhat.com>
Date: Thu Sep 24 14:15:17 2015 +1000
setup: moves import to where it's needed
This patch moves the asset import to the code where asset generation is
needed. That avoids a problem with the setup.py in which it fails if the
setup.py is run for a development egg.
Change-Id: I875bc05be8f1f45c5657164a63e07a0c48c67cb8
commit 8d15ce737aaa13d2d184dfe7cf87eaca73e9438c
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Sep 18 11:28:51 2015 +1000
test_util: fix test method naming
Test methods are supposed to start test_. Nose is finding these
currently because of its more generous test matching rules but py.test
will not.
Change-Id: I04107219712742a9777ea3a7694e15e30c3cd14d
commit 2ca228f83e37953058537d6c118fff6427aa6727
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Sep 18 11:16:45 2015 +1000
extracted unit tests for testinfo into a separate module
The unit tests embedded in the bkr.server.testinfo module were the only
test cases not adhering to the modern Python test discovery conventions,
which require that test cases be in a module named test_*.py.
Extracting them to a separate module will let us switch to py.test for
our test runner without the extra pain of making it find these
non-standard tests.
Change-Id: Id813f32ff4692498ecee073bca722e33ffa0ebb7
commit d3993d21b1509a3984ed19c9e19b170398566fed
Author: Matt Jia <mjia@redhat.com>
Date: Wed Sep 2 15:28:06 2015 +1000
port group editing page to Backbone
Bug: 1251356
Change-Id: I4b9e88190618b7d2798fe67f7e9e73a7a6efeeab
commit e8414727e0dcaf9954fe39f4328b60645c4de7ec
Author: Róman Joost <rjoost@redhat.com>
Date: Fri Aug 28 13:13:31 2015 +1000
powertype: refactored to JSON api
This patch refactores the powertype to use a json api. It also fixes the
keytypes test which failed due to a copy & paste error.
Bug: 1022461
Change-Id: I91775b5a7ba5bcec03b6543b20eb0aa4856a0275
commit a3b7a5edd220bf5a73298210bc7f212e1eec4307
Author: Roman Joost <rjoost@redhat.com>
Date: Tue Sep 8 14:38:59 2015 +1000
config: Don't minimise assets in development
Change-Id: I6ec67b8aedaab1f407f565daf24a36f40a963bd2
commit 3dcaaa29e720a670cabf366d9c99dc6ebcfdcfc0
Author: Matt Jia <mjia@redhat.com>
Date: Thu Sep 3 10:55:04 2015 +1000
add @admin_auth_required decorator
Change-Id: I496b3f5d508ee0990dc92074b751d1a9de66ca4b
commit 2210813041e7d9794b4154f1bf72794f12cb85ea
Author: Matt Jia <mjia@redhat.com>
Date: Wed Sep 2 16:25:07 2015 +1000
uncomment whats-new/next for develop
Change-Id: Ie40676f752af61c33bba7d29a490d57dba88ec1f
commit ce7587cc74d18d4af99f6e9552444d113310af23
Author: Roman Joost <rjoost@redhat.com>
Date: Mon Aug 3 15:19:58 2015 +1000
docs: Adds developer guide to main page
This patch adds an external link to the developer guide to improve
accessibility to our documentation resources for our developers.
Change-Id: I997a18dc3ca0475db631a037681f3e0dffbb4b2a
commit e9f39cc5cd6d6bc0afe188c68550c29d51a97ba2
Author: Matt Jia <mjia@redhat.com>
Date: Fri Aug 14 17:41:19 2015 +1000
tests:fix timing issue with pool update
Change-Id: I33475fad680729385f20a22319fa94aa0b107972
commit 4a7109ffbf0e8d10cab34a6d320d722995baae0f
Author: Dan Callaghan <dcallagh@redhat.com>
Date: Fri Aug 21 17:12:54 2015 +1000
SQL migration to delete old duplicate rows in osmajor_install_options
Bug: 1244996
Change-Id: I3e47776fe5eed7cc2f71883a29ea5e2ec9285d03
commit ca7a1efc15b9a896c2fb4ccaa2328a5633b54cd9
Author: Róman Joost <rjoost@redhat.com>
Date: Thu Aug 27 08:55:27 2015 +1000
system pools: adds test to verify view validation
This patch adds a test to verify the HTML validation to avoid creating
pools with an empty name.
Change-Id: I115e759267912922cab8202dd5ac3cf2a11ce57f
commit b7dafd832af950fdd2aede42281d76ec4ec0828d
Author: Roman Joost <rjoost@redhat.com>
Date: Mon Jul 27 16:57:15 2015 +1000
docs: additional information for verification
The patch adds additional information to verify the installation.
Change-Id: I900314a4925c0247d4068d2eca3c25b49771a831
commit 18409b9df7d59140a19f91d51d778b0e334e422a
Author: Alexander Todorov <atodorov@redhat.com>
Date: Tue Aug 11 13:14:56 2015 +0300
update description of jobs.filter() server API